Codeigniter PHP Сохранение данных в базе

как я уже сказал в разделе комментариев, вы здесь слишком усложняете - вы должны правильно организовать свои данные - в вашем случае лучше всего сделать это в своем контроллере

попробуйте следующее

ваш контроллер

public function add_prop()
{
    $arrPropertyDetails = [
        'account_id' => $this->session->userdata('login_id'),
        'td_arp_no' => sanitize($this->input->post('td_arp_no')),
        'pin' => sanitize($this->input->post('pin')),
        'owner' => sanitize($this->input->post('owner')),
        'tin' => sanitize($this->input->post('tin')),
        'address' => sanitize($this->input->post('address')),
        'tel_cell_no' => sanitize($this->input->post('tel_cell_no')),
        'administrator_user' => sanitize($this->input->post('administrator_user')),
        'tin_2' => sanitize($this->input->post('tin_2')),
        'address_2' => sanitize($this->input->post('address_2')),
        'tel_cell_no_2' => sanitize($this->input->post('tel_cell_no_2')),
        'status' => 1
    ];

    $arrPropertyLocation = [
        'prop_id' => '',
        'account_id' => $this->session->userdata('login_id'),
        'no_street' => sanitize($this->input->post('no_street')),
        'brgy' =>  sanitize($this->input->post('brgy')),
        'municipality' => sanitize($this->input->post('municipality')),
        'province_city' => sanitize($this->input->post('province_city')),
        'land_owner' => sanitize($this->input->post('land_owner')),
        'parcel_pin' => sanitize($this->input->post('parcel_pin')),
        'building_owner' => sanitize($this->input->post('building_owner')),
        'bldg_pin' => sanitize($this->input->post('bldg_pin')),
        'longitude' => sanitize($this->input->post('longitude')),
        'latitude' => sanitize($this->input->post('latitude'))
    ];

    $propertyId = $this->LandClientModel->add_prop($arrPropertyDetails, $arrPropertyLocation);

    $data = [
        "success" => 1,
        "prop_id" => $propertyId
    ];
    generate_json($data);
}

ваша модель

public function add_prop($arrPropertyDetails, $arrPropertyLocation)
{
    $this->db->insert('land_property_details', $arrPropertyDetails);
    $id = $this->db->insert_id();
    $arrPropertyLocation['prop_id'] = $id;
    $this->db->insert('land_property_location', $arrPropertyLocation);
    return $id;
}

Если у вас проблемы с данными - вы просто распечатываете свои массивы в своем контроллере.

использовать массив в контроллере

public function add_prop()
{
$data=array();
$insertArray=array(
     $account_id = $this->session->userdata('login_id'),
    $td_arp_no = sanitize($this->input->post('td_arp_no')),
    $owner = sanitize($this->input->post('owner')),
    $address = sanitize($this->input->post('address')),
    $administrator_user = sanitize($this->input->post('administrator_user')),
    $address_2 = sanitize($this->input->post('address_2')),
    $pin = sanitize($this->input->post('pin')),
    $tin = sanitize($this->input->post('tin')),
    $tel_cell_no = sanitize($this->input->post('tel_cell_no')),
    $tin_2 = sanitize($this->input->post('tin_2')),
    $tel_cell_no_2 = sanitize($this->input->post('td_arp_no')));
if ($this->model_name->add_prop($insertArray)){
 // property location form
$insertArray2=array(
 $no_street = sanitize($this->input->post('no_street')),
    $municipality = sanitize($this->input->post('municipality')),
    $land_owner = sanitize($this->input->post('land_owner')),
    $building_owner = sanitize($this->input->post('building_owner')),
    $longitude = sanitize($this->input->post('longitude')),
    $brgy = sanitize($this->input->post('brgy')),
    $province_city = sanitize($this->input->post('province_city')),
    $parcel_pin = sanitize($this->input->post('parcel_pin')),
    $bldg_pin = sanitize($this->input->post('bldg_pin')),
    $latitude = sanitize($this->input->post('td_arp_no')));
if ($this->model_name->methodname($insertArray2)){
//sccess message
}
    }
}

//модель

function add_prop($insertArray) {
        if ($this->db->insert('land_property_details', $insertArray) > 0) {
            return $this->db->insert_id();
        }
        return 0;
    }

function methodname($insertArray2) {
        if ($this->db->insert('land_property_location', $insertArray2) > 0) {
            return $this->db->insert_id();
        }
        return 0;
    }