Проблемы с попыткой использовать Update и Create в одной функции

Вы пытаетесь обновить пользователя, не передавая его идентификатор, что наверняка приведет к ошибке.

Попробуй это:

public function createuserinfo(Request $request)
{ 
 $user = Auth::user();

 $userupdate = User::find($user->id);
 $userupdate->status = '1';
 $userupdate->save();

 $infocreate = Personal::create([
        'user_id' => $user->id,
        'first_name' => $request->first_name,
        'last_name' => $request->last_name,
        'email' => $request->email,
        'password' => $request->password,
        'address' => $request->address,
        'zipcode' => $request->zipcode,
        'city' => $request->city,
        'phone_number' => $request->phone_number,
        'ss_number' => $request->ss_number,
        'document_number' => $request->document_number,
        'license_number' => $request->license_number,
        'expiration_date' => $request->expiration_date,
        'employer' => $request->employer,
        'jobtitle' => $request->jobtitle,
        'contract' => $request->contract,
        'start_date' => $request->start_date,
        'general_practitioner' => $request->general_practitioner,
        'dentist' => $request->dentist,
        'health_insurance' => $request->health_insurance,
        'contact_one_name' => $request->contact_one_name,
        'contact_one_relation' => $request->contact_one_relation,
        'contact_one_address' => $request->contact_one_address,
        'contact_one_zipcode' => $request->contact_one_zipcode,
        'contact_one_city' => $request->contact_one_city,
        'contact_one_phone_number' => $request->contact_one_phone_number,
        'contact_two_name' => $request->contact_two_name,
        'contact_two_relation' => $request->contact_two_relation,
        'contact_two_address' => $request->contact_two_address,
        'contact_two_zipcode' => $request->contact_two_zipcode,
        'contact_two_city' => $request->contact_two_city,
        'contact_two_phone_number' => $request->contact_two_phone_number
    ]);

    return $userupdate . $infocreate . redirect()->route('users.details');
}

Может быть, попробовать это

  public function createuserinfo(Request $request)
{
    $user = Auth::user();

    $userupdate = $user->update([
        'status' => '1'
    ]);

    $infocreate = Personal::create([
        'user_id' => $user->id,
        'first_name' => $request->first_name,
        'last_name' => $request->last_name,
        'email' => $request->email,
        'password' => $request->password,
        'address' => $request->address,
        'zipcode' => $request->zipcode,
        'city' => $request->city,
        'phone_number' => $request->phone_number,
        'ss_number' => $request->ss_number,
        'document_number' => $request->document_number,
        'license_number' => $request->license_number,
        'expiration_date' => $request->expiration_date,
        'employer' => $request->employer,
        'jobtitle' => $request->jobtitle,
        'contract' => $request->contract,
        'start_date' => $request->start_date,
        'general_practitioner' => $request->general_practitioner,
        'dentist' => $request->dentist,
        'health_insurance' => $request->health_insurance,
        'contact_one_name' => $request->contact_one_name,
        'contact_one_relation' => $request->contact_one_relation,
        'contact_one_address' => $request->contact_one_address,
        'contact_one_zipcode' => $request->contact_one_zipcode,
        'contact_one_city' => $request->contact_one_city,
        'contact_one_phone_number' => $request->contact_one_phone_number,
        'contact_two_name' => $request->contact_two_name,
        'contact_two_relation' => $request->contact_two_relation,
        'contact_two_address' => $request->contact_two_address,
        'contact_two_zipcode' => $request->contact_two_zipcode,
        'contact_two_city' => $request->contact_two_city,
        'contact_two_phone_number' => $request->contact_two_phone_number
    ]);

    return $userupdate . $infocreate . redirect()->route('users.details');
}

Вместо static вызова User модели используйте тот же объект.

    $user = Auth::user();
    $updateUser = $user->update('status' => '1']);

Также вы можете использовать метод save.

    $user = Auth::user();
    $user->status = '1';
    $user->save();

Ссылка Красноречивый ORM

У вас есть функция laravel для этого createOrUpdate(). И если вы обновляете строку с помощью update(), вам нужно указать, что вы обновляете.

Вы хотите обновить пользователя с помощью User::update(), но Модель не знает, какой пользователь, если вы это сделаете

User::find(1)->update() or User::where('name', 'test')->update() 

оно бы знало.

или в вашем случае

$user = Auth::user();

 $user->update([
    'status' => '1'
 ]);